pdxcodemonkey commented on a change in pull request #697:
URL: https://github.com/apache/geode-native/pull/697#discussion_r542603711
##########
File path: cppcache/src/TcrConnection.hpp
##########
@@ -120,43 +109,12 @@ class TcrConnection {
* @param ports List of local ports for connections to endpoint
*/
bool initTcrConnection(
- TcrEndpoint* endpointObj, const char* endpoint,
+ std::shared_ptr<TcrEndpoint> endpointObj,
Review comment:
I suppose thanks are due to @mreddington then :). Either way, this is
much better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
