mmartell commented on a change in pull request #714:
URL: https://github.com/apache/geode-native/pull/714#discussion_r544649782
##########
File path: tests/javaobject/cli/InstantiateDataSerializable.java
##########
@@ -32,15 +32,16 @@
public class InstantiateDataSerializable extends FunctionAdapter implements
Declarable{
public void execute(FunctionContext context) {
- Instantiator.register(new Instantiator(javaobject.cli.Position.class, 22) {
+
+ Instantiator.register(new Instantiator(javaobject.cli.PositionKey.class, 21)
{
public DataSerializable newInstance() {
- return new javaobject.cli.Position();
+ return new javaobject.cli.PositionKey();
}
});
- Instantiator.register(new Instantiator(javaobject.cli.PositionKey.class, 77)
{
Review comment:
Yes. All tests updated and pass. I had to use something other than 77,
as it was causing a conflict (don't remember where). Chose 21 for PositionKey
since it was unused and close to Position (22).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
