pivotal-jbarrett commented on a change in pull request #714:
URL: https://github.com/apache/geode-native/pull/714#discussion_r544788402
##########
File path: cppcache/integration/test/Position.cpp
##########
@@ -41,19 +41,19 @@ Position::Position(std::string id, int32_t
outstandingShares) {
void Position::init() {
Review comment:
Good C++ practice would sanitize this to an list of initializations on a
common constructor. `std::string` initializes to `""` already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
