pivotal-jbarrett commented on a change in pull request #5905: URL: https://github.com/apache/geode/pull/5905#discussion_r562284968
########## File path: geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/CommandInitializerTest.java ########## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ + +package org.apache.geode.internal.cache.tier.sockets; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.verifyNoMoreInteractions; + +import java.util.HashMap; +import java.util.Map; + +import org.junit.Test; + +import org.apache.geode.internal.cache.tier.Command; +import org.apache.geode.internal.cache.tier.MessageType; +import org.apache.geode.internal.cache.tier.sockets.command.AddPdxEnum; +import org.apache.geode.internal.cache.tier.sockets.command.AddPdxType; +import org.apache.geode.internal.cache.tier.sockets.command.ClearRegion; +import org.apache.geode.internal.cache.tier.sockets.command.ClientReady; +import org.apache.geode.internal.cache.tier.sockets.command.CloseConnection; +import org.apache.geode.internal.cache.tier.sockets.command.CommitCommand; +import org.apache.geode.internal.cache.tier.sockets.command.ContainsKey66; +import org.apache.geode.internal.cache.tier.sockets.command.CreateRegion; +import org.apache.geode.internal.cache.tier.sockets.command.Destroy70; +import org.apache.geode.internal.cache.tier.sockets.command.DestroyRegion; +import org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction70; +import org.apache.geode.internal.cache.tier.sockets.command.ExecuteRegionFunction66; +import org.apache.geode.internal.cache.tier.sockets.command.ExecuteRegionFunctionGeode18; +import org.apache.geode.internal.cache.tier.sockets.command.ExecuteRegionFunctionSingleHop; +import org.apache.geode.internal.cache.tier.sockets.command.GatewayReceiverCommand; +import org.apache.geode.internal.cache.tier.sockets.command.Get70; +import org.apache.geode.internal.cache.tier.sockets.command.GetAll70; +import org.apache.geode.internal.cache.tier.sockets.command.GetAllWithCallback; +import org.apache.geode.internal.cache.tier.sockets.command.GetClientPRMetadataCommand66; +import org.apache.geode.internal.cache.tier.sockets.command.GetClientPartitionAttributesCommand66; +import org.apache.geode.internal.cache.tier.sockets.command.GetEntry70; +import org.apache.geode.internal.cache.tier.sockets.command.GetFunctionAttribute; +import org.apache.geode.internal.cache.tier.sockets.command.GetPDXEnumById; +import org.apache.geode.internal.cache.tier.sockets.command.GetPDXIdForEnum; +import org.apache.geode.internal.cache.tier.sockets.command.GetPDXIdForType; +import org.apache.geode.internal.cache.tier.sockets.command.GetPDXTypeById; +import org.apache.geode.internal.cache.tier.sockets.command.GetPdxEnums70; +import org.apache.geode.internal.cache.tier.sockets.command.GetPdxTypes70; +import org.apache.geode.internal.cache.tier.sockets.command.Invalid; +import org.apache.geode.internal.cache.tier.sockets.command.Invalidate70; +import org.apache.geode.internal.cache.tier.sockets.command.KeySet; +import org.apache.geode.internal.cache.tier.sockets.command.MakePrimary; +import org.apache.geode.internal.cache.tier.sockets.command.PeriodicAck; +import org.apache.geode.internal.cache.tier.sockets.command.Ping; +import org.apache.geode.internal.cache.tier.sockets.command.Put70; +import org.apache.geode.internal.cache.tier.sockets.command.PutAll80; +import org.apache.geode.internal.cache.tier.sockets.command.PutAllWithCallback; +import org.apache.geode.internal.cache.tier.sockets.command.PutUserCredentials; +import org.apache.geode.internal.cache.tier.sockets.command.Query651; +import org.apache.geode.internal.cache.tier.sockets.command.QueryGeode10; +import org.apache.geode.internal.cache.tier.sockets.command.QueryWithParametersGeode10; +import org.apache.geode.internal.cache.tier.sockets.command.RegisterDataSerializers; +import org.apache.geode.internal.cache.tier.sockets.command.RegisterInstantiators; +import org.apache.geode.internal.cache.tier.sockets.command.RegisterInterest61; +import org.apache.geode.internal.cache.tier.sockets.command.RegisterInterestList66; +import org.apache.geode.internal.cache.tier.sockets.command.RemoveAll; +import org.apache.geode.internal.cache.tier.sockets.command.RemoveUserAuth; +import org.apache.geode.internal.cache.tier.sockets.command.RequestEventValue; +import org.apache.geode.internal.cache.tier.sockets.command.RollbackCommand; +import org.apache.geode.internal.cache.tier.sockets.command.Size; +import org.apache.geode.internal.cache.tier.sockets.command.TXFailoverCommand; +import org.apache.geode.internal.cache.tier.sockets.command.TXSynchronizationCommand; +import org.apache.geode.internal.cache.tier.sockets.command.UnregisterInterest; +import org.apache.geode.internal.cache.tier.sockets.command.UnregisterInterestList; +import org.apache.geode.internal.cache.tier.sockets.command.UpdateClientNotification; +import org.apache.geode.internal.serialization.KnownVersion; + +public class CommandInitializerTest { + + @Test + public void testCommandMapContainsAllVersions() { + for (KnownVersion version : KnownVersion.getAllVersions()) { + if (version.isNotOlderThan(KnownVersion.OLDEST)) { + org.junit.Assert.assertNotNull( + "Please add a command set for " + version + " of Geode to CommandInitializer", + CommandInitializer.getDefaultInstance().get(version)); + } + } + } + + @Test + public void initializeGeode18Commands() { + @SuppressWarnings("unchecked") + final Map<Integer, Command> commands = mock(Map.class); Review comment: Honestly I could delete this test. There is an integration test that does pretty much what you describe. The rational for this test was to assert that I didn't have any duplicates when I refactored each of the versions. Checking the map wouldn't weed out two puts on the same key but this does. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
