Bill commented on a change in pull request #5905:
URL: https://github.com/apache/geode/pull/5905#discussion_r562792290
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/BackwardCompatibilitySerializationDUnitTest.java
##########
@@ -160,7 +149,7 @@ public void testFromDataFromLowerVersionToHigher() throws
Exception {
public void testAllMessages() throws Exception {
// list of msgs not created using reflection
// taken from DSFIDFactory.create()
- ArrayList<Integer> constdsfids = new ArrayList<Integer>();
+ ArrayList<Integer> constdsfids = new ArrayList<>();
Review comment:
My comment was based on a quick read of the comment in the test method.
That sent me over to `DSFIDFactory.create` where I found more cases than were
accounted for in the test. Made me think those were added after the test and
that we forgot to add them to the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
