gaussianrecurrence commented on a change in pull request #678:
URL: https://github.com/apache/geode-native/pull/678#discussion_r561716554
##########
File path: cppcache/integration-test/CMakeLists.txt
##########
@@ -25,6 +25,7 @@ add_library(test-cppcache-utils STATIC
target_link_libraries(test-cppcache-utils
PRIVATE
ACE::ACE
+ Boost::boost
Review comment:
After changing CacheStatistics this is not needed anymore. Thanks!
##########
File path: cppcache/integration-test/CMakeLists.txt
##########
@@ -114,6 +115,7 @@ endif()
target_link_libraries(${TEST}
PRIVATE
ACE::ACE
+ Boost::boost
Review comment:
After changing CacheStatistics this is not needed anymore. Thanks!
##########
File path: clicache/src/DistributedSystem.cpp
##########
@@ -404,9 +404,9 @@ namespace Apache
void DistributedSystem::HandleMemoryPressure(System::Object^ state)
{
// TODO global - Need single memory pressue event running?
Review comment:
I am curious about why do we need this method at all. As far as I've
seen it's not used anywhere
##########
File path: clicache/src/impl/MemoryPressureTask.hpp
##########
@@ -30,14 +30,14 @@ namespace Apache
namespace Client
{
- class MemoryPressureHandler
- : public ACE_Event_Handler
+ class MemoryPressureTask
+ : public apache::geode::client::ExpiryTask
Review comment:
Thanks for pointing it. Seems that C# part does not have any
auto-formatting :S
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
