gaussianrecurrence commented on a change in pull request #678:
URL: https://github.com/apache/geode-native/pull/678#discussion_r592751782
##########
File path: cppcache/integration-test/CMakeLists.txt
##########
@@ -114,6 +115,7 @@ endif()
target_link_libraries(${TEST}
PRIVATE
ACE::ACE
+ Boost::boost
Review comment:
After carefully looking at this I've noticed that new integration tests
also include Boost library.
Thing is symbols are not needed from Boost library for integrations test,
but compilation flags from the library.
Thing is in order to ignore clang-tidy checks for boost you need to include
it as a system library, which is what's achieved by "linking" the library.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]