Bill commented on a change in pull request #5905:
URL: https://github.com/apache/geode/pull/5905#discussion_r562956354
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientSideHandshakeImpl.java
##########
@@ -336,20 +333,17 @@ public ServerQueueStatus
handshakeWithSubscriptionFeed(Socket sock, boolean isPr
if (currentClientVersion.isOlderThan(KnownVersion.GFE_61)) {
return new ServerQueueStatus(endpointType, queueSize, member);
}
- HashMap instantiatorMap = DataSerializer.readHashMap(dis);
- for (Iterator itr = instantiatorMap.entrySet().iterator();
itr.hasNext();) {
- Map.Entry instantiator = (Map.Entry) itr.next();
- Integer id = (Integer) instantiator.getKey();
- ArrayList instantiatorArguments = (ArrayList) instantiator.getValue();
- InternalInstantiator.register((String) instantiatorArguments.get(0),
- (String) instantiatorArguments.get(1), id, false);
+ final Map<Integer, List<String>> instantiatorMap =
DataSerializer.readHashMap(dis);
+ for (final Map.Entry<Integer, List<String>> entry :
instantiatorMap.entrySet()) {
Review comment:
just a suggestion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
