gesterzhou commented on a change in pull request #5843:
URL: https://github.com/apache/geode/pull/5843#discussion_r568174860
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java
##########
@@ -104,6 +122,26 @@ public DistributionLocatorId(InetAddress host, int port,
String bindAddress, SSL
* two.
*/
public DistributionLocatorId(String marshalled) {
+ this(marshalled, null);
+ }
+
+ /**
+ * Constructs a DistributionLocatorId with a String of the form:
hostname[port] or
+ * hostname:bindaddress[port] or hostname@bindaddress[port]
+ * and membername
+ * <p>
+ * The :bindaddress portion is optional. hostname[port] is the more common
form.
+ * <p>
+ * Example: merry.gemstone.com[7056]<br>
+ * Example w/ bind address: merry.gemstone.com:81.240.0.1[7056], or
+ * merry.gemstone.com@fdf0:76cf:a0ed:9449::16[7056]
Review comment:
is this "::" a typo here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
