gesterzhou commented on a change in pull request #5843:
URL: https://github.com/apache/geode/pull/5843#discussion_r568179833
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java
##########
@@ -317,6 +363,43 @@ public boolean equals(Object other) {
return false;
final DistributionLocatorId that = (DistributionLocatorId) other;
+ if (this.membername != null && that.membername != null) {
+ if (this.membername.equals(that.membername))
+ return true;
+
+ return false;
+ }
+
+ if (!StringUtils.equals(this.hostnameForClients, that.hostnameForClients))
+ return false;
+ if (this.host != that.host && !(this.host != null &&
this.host.equals(that.host)))
Review comment:
Should it be:
if (this.host != null && !this.host.equals(that.host))
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
