ringles commented on a change in pull request #5978:
URL: https://github.com/apache/geode/pull/5978#discussion_r574129048
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/EntryEventImpl.java
##########
@@ -1713,10 +1713,11 @@ private void setNewValueInRegion(final InternalRegion
owner, final RegionEntry r
// This is a horrible hack, but we need to get the size of the object
// When we store an entry. This code is only used when we do a put
// in the primary.
- if (v instanceof org.apache.geode.Delta &&
getRegion().isUsedForPartitionedRegionBucket()) {
+ if (v instanceof Delta && getRegion().isUsedForPartitionedRegionBucket()) {
int vSize;
Object ov = basicGetOldValue();
- if (ov instanceof CachedDeserializable &&
!GemFireCacheImpl.DELTAS_RECALCULATE_SIZE) {
+ if (ov instanceof CachedDeserializable &&
!(GemFireCacheImpl.DELTAS_RECALCULATE_SIZE
Review comment:
Thanks for the very clear and thorough comment! I've taken your advice
by breaking out the method and unit-testing it; I did rearrange and rename the
tests slightly, though. I think it makes the intent a bit clearer but let me
know if it can be improved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
