ringles commented on a change in pull request #5978:
URL: https://github.com/apache/geode/pull/5978#discussion_r577784898
##########
File path: geode-core/src/main/java/org/apache/geode/Delta.java
##########
@@ -53,7 +51,27 @@
* This method throws an {@link InvalidDeltaException} when the delta in the
{@link DataInput}
* cannot be applied to the object. GemFire automatically handles an {@link
InvalidDeltaException}
* by reattempting the update by sending the full application object.
- *
*/
void fromDelta(DataInput in) throws IOException, InvalidDeltaException;
+
+ /**
Review comment:
gemfire.DELTAS_RECALCULATE_SIZE is not new; it's been around since at
least 2017 (git-annotate shows "4/24/17 Lund") and its definition was tweaked
"12/11/19 Lund". (Though that was a large commit touching a lot of files.)
It probably makes sense to document it somewhere else, too, but it seems
relevant here...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
