kirklund commented on a change in pull request #5970:
URL: https://github.com/apache/geode/pull/5970#discussion_r577027836
##########
File path:
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java
##########
@@ -140,7 +140,7 @@ public void testGetAttributeNames() {
// are.
assertEquals(36, boolList.size());
assertEquals(35, intList.size());
- assertEquals(88, stringList.size());
+ assertEquals(89, stringList.size());
Review comment:
I generally update every test I touch to use AssertJ instead of JUnit
Assertions. There's a great IntelliJ plugin that will do the bulk of the work
for you called **Assertions2AssertJ**. For example, using this plugin adds a
new menu item to "**Refactor -> Convert Assertions to AssertJ**".
I always review the changes made by the plugin though. Sometimes it doesn't
pick the best assertion method (such as `isEqual` instead of `hasSize`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
