alb3rtobr commented on a change in pull request #5970:
URL: https://github.com/apache/geode/pull/5970#discussion_r580599995
##########
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommand.java
##########
@@ -120,25 +121,32 @@ public ResultModel startLocator(
help = CliStrings.START_LOCATOR__HTTP_SERVICE_BIND_ADDRESS__HELP)
final String httpServiceBindAddress,
@CliOption(key = CliStrings.START_LOCATOR__REDIRECT_OUTPUT,
unspecifiedDefaultValue = "false",
specifiedDefaultValue = "true",
- help = CliStrings.START_LOCATOR__REDIRECT_OUTPUT__HELP) final
Boolean redirectOutput)
+ help = CliStrings.START_LOCATOR__REDIRECT_OUTPUT__HELP) final
Boolean redirectOutput,
+ @CliOption(key = CliStrings.START_LOCATOR__MEMBERSHIP_BIND_ADDRESS,
+ help = CliStrings.START_LOCATOR__MEMBERSHIP_BIND_ADDRESS__HELP)
final String membershipBindAddress)
throws Exception {
if (StringUtils.isBlank(memberName)) {
// when the user doesn't give us a name, we make one up!
memberName = StartMemberUtils.getNameGenerator().generate('-');
}
- workingDirectory = StartMemberUtils.resolveWorkingDir(
- workingDirectory == null ? null : new File(workingDirectory), new
File(memberName));
+ workingDirectory = resolveWorkingDirectory(workingDirectory, memberName);
return doStartLocator(memberName, bindAddress, classpath, force, group,
hostnameForClients,
jmxManagerHostnameForClients, includeSystemClasspath, locators,
logLevel, mcastBindAddress,
mcastPort, port, workingDirectory, gemfirePropertiesFile,
gemfireSecurityPropertiesFile,
initialHeap, maxHeap, jvmArgsOpts, connect, enableSharedConfiguration,
loadSharedConfigurationFromDirectory, clusterConfigDir,
httpServicePort,
- httpServiceBindAddress, redirectOutput);
+ httpServiceBindAddress, redirectOutput, membershipBindAddress);
}
+ @VisibleForTesting
+ protected static String resolveWorkingDirectory(String workDirValue, String
memberName) {
Review comment:
> I've marked some changes involving logging, AssertJ, and minor clean
code design issues.
Thanks for the review @kirklund , I think I have fixed all the issues in the
last commit, please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
