moleske commented on a change in pull request #750:
URL: https://github.com/apache/geode-native/pull/750#discussion_r581217892
##########
File path: ci/lib/templates.lib.txt
##########
@@ -72,43 +72,12 @@ function remote_upload {
(@- end @)
-(@ def run_cpp_unit_tests(): -@)
+(@ def ctest_bash_task(path, timeout=300, parallel=6): -@)
set -ueo pipefail
(@= remote_functions() @)
-remote_shell cmake -E chdir build/cppcache/test ctest -C ${CMAKE_CONFIG} -j8
--timeout=500 --output-on-failure --schedule-random
Review comment:
Random side note: I don't think the unit tests respect the
`--schedule-random` flag through cmake, though I'm having trouble finding
evidence in docs one way or the other. I know that executing the binary
directly like `apache-geode_unittests --gtest_shuffle` definitely shuffles the
unit tests, though that would destroy the simplification here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
