pivotal-jbarrett commented on a change in pull request #750:
URL: https://github.com/apache/geode-native/pull/750#discussion_r581349442
##########
File path: ci/lib/templates.lib.txt
##########
@@ -72,43 +72,12 @@ function remote_upload {
(@- end @)
-(@ def run_cpp_unit_tests(): -@)
+(@ def ctest_bash_task(path, timeout=300, parallel=6): -@)
set -ueo pipefail
(@= remote_functions() @)
-remote_shell cmake -E chdir build/cppcache/test ctest -C ${CMAKE_CONFIG} -j8
--timeout=500 --output-on-failure --schedule-random
Review comment:
Eh! Random isn't important there unless you're writing bad tests. I
errored on the side of consistency in the args.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
