pivotal-jbarrett commented on a change in pull request #750:
URL: https://github.com/apache/geode-native/pull/750#discussion_r581395832
##########
File path: CMakeLists.txt
##########
@@ -139,13 +137,8 @@ string(REGEX REPLACE " " "" IGNORED_FULL "${IGNORED_FULL}")
list(APPEND CPACK_SOURCE_IGNORE_FILES ${IGNORED_FULL})
-if(CMAKE_GENERATOR MATCHES Win64*)
- set(CMAKE_GENERATOR_TOOLSET "host=x64")
-else()
- set(CMAKE_GENERATOR_TOOLSET )
-endif()
-
Review comment:
That line never really worked and is an anti-pattern in CMake so I
clubbed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
