pivotal-jbarrett commented on a change in pull request #6050:
URL: https://github.com/apache/geode/pull/6050#discussion_r581460673
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientSideHandshakeImpl.java
##########
@@ -355,7 +355,10 @@ private byte write(DataOutputStream dos, DataInputStream
dis, CommunicationMode
// for testing
VersioningIO.writeOrdinal(hdos, overrideClientVersion, true);
} else {
- VersioningIO.writeOrdinal(hdos, currentClientVersion.ordinal(), true);
+ VersioningIO.writeOrdinal(hdos,
+ communicationMode.isWAN() ? KnownVersion.CURRENT_ORDINAL
Review comment:
More for curiosity but why can't WAN utilize the version checking?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
