bschuchardt commented on a change in pull request #6050:
URL: https://github.com/apache/geode/pull/6050#discussion_r582305997
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientSideHandshakeImpl.java
##########
@@ -355,7 +355,10 @@ private byte write(DataOutputStream dos, DataInputStream
dis, CommunicationMode
// for testing
VersioningIO.writeOrdinal(hdos, overrideClientVersion, true);
} else {
- VersioningIO.writeOrdinal(hdos, currentClientVersion.ordinal(), true);
+ VersioningIO.writeOrdinal(hdos,
+ communicationMode.isWAN() ? KnownVersion.CURRENT_ORDINAL
Review comment:
that I don't know. We may want to change that, but WAN does some fancy
& mysterious things in the handshake code and elsewhere and I wasn't sure it
would be okay to roll its comms back to 1.8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
