pivotal-eshu commented on a change in pull request #6051:
URL: https://github.com/apache/geode/pull/6051#discussion_r582427022



##########
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedCacheOperation.java
##########
@@ -1107,6 +1107,10 @@ protected void process(final ClusterDistributionManager 
dm) {
 
         final LocalRegion lclRgn = getLocalRegionForProcessing(dm);
         sendReply = false;
+        if (lclRgn != null && lclRgn.getScope().isDistributedNoAck()) {
+          dm.getExecutors().getWaitingThreadPool().execute(() -> 
basicProcess(dm, lclRgn));

Review comment:
       In basicProcess call (using waiting thread pool for distributed-no-ack 
regions), CancelException is also caught and handled.
   catch (RegionDestroyedException ignore) {
           this.closed = true;
           if (logger.isDebugEnabled()) {
             logger.debug("{} Region destroyed: nothing to do", this);
           }
         } catch (CancelException ignore) {
           this.closed = true;
           if (logger.isDebugEnabled()) {
             logger.debug("{} Cancelled: nothing to do", this);
           }
         }




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to