jchen21 commented on a change in pull request #6051:
URL: https://github.com/apache/geode/pull/6051#discussion_r583317242
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedCacheOperation.java
##########
@@ -1107,6 +1107,10 @@ protected void process(final ClusterDistributionManager
dm) {
final LocalRegion lclRgn = getLocalRegionForProcessing(dm);
sendReply = false;
+ if (lclRgn != null && lclRgn.getScope().isDistributedNoAck()) {
+ dm.getExecutors().getWaitingThreadPool().execute(() ->
basicProcess(dm, lclRgn));
Review comment:
Good point. For `basicProcess()`, if debug is not enabled, some
exceptions are caught, but not logged, although some flags are set, when the
exceptions are caught. Will the new thread fail silently with such exceptions,
if debug is not enabled?
And even for `process()`, logging the exceptions also depends on whether
debug is enabled. I am not sure whether this is by design. If debug is not
enabled, without the log message, it is hard to analyze the failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
