pivotal-jbarrett commented on a change in pull request #774:
URL: https://github.com/apache/geode-native/pull/774#discussion_r600617196
##########
File path: cppcache/src/DistributedSystemImpl.cpp
##########
@@ -81,9 +81,9 @@ void DistributedSystemImpl::logSystemInformation() const {
ACE_utsname u;
ACE_OS::uname(&u);
- LOGCONFIG(
- "Running on: SystemName=%s Machine=%s Host=%s Release=%s Version=%s",
- u.sysname, u.machine, u.nodename, u.release, u.version);
+ LOGCONFIG("Running on: SystemName=" BOOST_PLATFORM
Review comment:
A really important distinction here is that `BOOST_PLATFORM` is resolved
at compile time, while `ACE_OS::name` is resolved at runtime. What are you
thinking for the other components here? Roll our own system independent
solution like `ACE_OS::uname`? When I looked into this I couldn't find a
different path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
