pivotal-jbarrett commented on a change in pull request #774:
URL: https://github.com/apache/geode-native/pull/774#discussion_r600746320
##########
File path: cppcache/src/DistributedSystemImpl.cpp
##########
@@ -81,9 +81,9 @@ void DistributedSystemImpl::logSystemInformation() const {
ACE_utsname u;
ACE_OS::uname(&u);
- LOGCONFIG(
- "Running on: SystemName=%s Machine=%s Host=%s Release=%s Version=%s",
- u.sysname, u.machine, u.nodename, u.release, u.version);
+ LOGCONFIG("Running on: SystemName=" BOOST_PLATFORM
Review comment:
It is not uncommon for the person collecting the logs to have little
knowledge of the host details so I suspect support staff will not be happy if
the are working with a customer who can't tell them what OS and version a log
came from. In general I agree though that this is ephemeral information. It is
also pretty easy to create the platform independent. You can look to the ACE
implementation for hints on how to do the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
