boglesby commented on a change in pull request #6036:
URL: https://github.com/apache/geode/pull/6036#discussion_r605289485
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParser.java
##########
@@ -642,6 +660,16 @@ private void startGatewaySender(Attributes atts) {
gatewaySenderFactory.setPersistenceEnabled(Boolean.parseBoolean(enablePersistence));
}
+ // Gateway-sender state
+ String state = atts.getValue(STATE);
+ if (Objects.equals(state, GatewaySenderState.RUNNING.getState()) ||
+ Objects.equals(state, GatewaySenderState.STOPPED.getState()) ||
+ Objects.equals(state, GatewaySenderState.PAUSED.getState())) {
+
gatewaySenderFactory.setState(GatewaySenderState.valueOf(state.toUpperCase()));
+ } else {
+ gatewaySenderFactory.setState(null);
Review comment:
You probably should throw an exception here if an invalid state is used
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheXmlGenerator.java
##########
@@ -1373,6 +1373,11 @@ private void generateGatewaySender(GatewaySender sender)
throws SAXException {
if (generateDefaults() || sender.getAlertThreshold() !=
GatewaySender.DEFAULT_ALERT_THRESHOLD)
atts.addAttribute("", "", ALERT_THRESHOLD, "",
String.valueOf(sender.getAlertThreshold()));
+ // gateway-sender state
+ if (sender.getState() != null) {
+ atts.addAttribute("", "", STATE, "", sender.getState().getState());
+ }
+
Review comment:
You probably need a unit test for this change. See
CacheXmlGeode10DUnitTest.
##########
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/functions/GatewaySenderFunctionArgs.java
##########
@@ -47,6 +47,7 @@
private final List<String> gatewayEventFilters;
private final List<String> gatewayTransportFilters;
private final Boolean enforceThreadsConnectSameReceiver;
+ private final String state;
Review comment:
The GatewaySenderFunctionArgs defines a state field. That object is only
used by the CreateGatewaySenderCommand. The CreateGatewaySenderCommand doesn't
have any way to set the state when a sender is created. Should it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
