mkevo commented on a change in pull request #6225:
URL: https://github.com/apache/geode/pull/6225#discussion_r609389175
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
##########
@@ -1881,9 +1881,8 @@ public void
handleManagerDeparture(InternalDistributedMember theId, boolean memb
removeHostedLocators(theId);
redundancyZones.remove(theId);
- if (theId.getVmKind() != ClusterDistributionManager.LOCATOR_DM_TYPE) {
- stats.incNodes(-1);
- }
+ stats.incNodes(-1);
+
Review comment:
In the description of this attribute state the following:
`The current number of nodes in this distributed system visible to this
member.`
What are nodes there, both locators and servers or just servers?
Also, should the current server be visible to itself?
If we go with @jinmeiliao proposal we should change the description to be
more clear.
`The current number of servers in this distributed system visible to this
member.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
