kirklund commented on a change in pull request #6225:
URL: https://github.com/apache/geode/pull/6225#discussion_r617959313
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
##########
@@ -350,13 +350,13 @@ static ClusterDistributionManager
create(InternalDistributedSystem system,
}
}
}
+ } else {
+ distributionManager.addNewMember(id); // add ourselves
Review comment:
This block of code needs to addNewMember even when the name is "". Why
does it need to move it into an else-block?
If you start a Geode process without using `start locator` or `start
server`, you can do so without a `name` but it's still a new member.
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
##########
@@ -1793,9 +1793,7 @@ private String prettifyReason(String r) {
*/
private void handleManagerStartup(InternalDistributedMember theId) {
// Note test is under membersLock
- if (theId.getVmKind() != ClusterDistributionManager.LOCATOR_DM_TYPE) {
- stats.incNodes(1);
- }
+ stats.incNodes(1);
Review comment:
I think @Bill @bschuchardt or @dschneider-pivotal should review this
change instead of me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
