upthewaterspout commented on a change in pull request #147:
URL: https://github.com/apache/geode-benchmarks/pull/147#discussion_r617786441
##########
File path:
harness/src/main/java/org/apache/geode/perftest/yardstick/YardstickTask.java
##########
@@ -107,6 +112,35 @@ public String defaultDescription() {
runner.runBenchmark();
- testDoneProbe.await();
+ Histogram lastHistogram = hdrHistogramProbe.getHistogram();
+ while (!testDoneProbe.await(10, TimeUnit.SECONDS)) {
Review comment:
I'm not sure if there is a way we can pause yardstick during this
measurement without just throwing away yardstick. I can do a test to see if
there is any impact from this. I was originally thinking that since we only
really care about relative performance, it doesn't matter if we impact the perf
of both the baseline and the test versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
