nonbinaryprogrammer commented on a change in pull request #147:
URL: https://github.com/apache/geode-benchmarks/pull/147#discussion_r620532745
##########
File path:
harness/src/main/java/org/apache/geode/perftest/yardstick/YardstickTask.java
##########
@@ -107,6 +112,35 @@ public String defaultDescription() {
runner.runBenchmark();
- testDoneProbe.await();
+ Histogram lastHistogram = hdrHistogramProbe.getHistogram();
+ while (!testDoneProbe.await(10, TimeUnit.SECONDS)) {
Review comment:
is calculating the histogram reliable in how long it takes? Does it take
longer as we get more data? I could see how we'd account for it if it always
takes the same amount of time, but a variable time doesn't seem possible to
account for. I don't think we can assume that the relative performance impact
would be the same between runs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
