jdeppe-pivotal opened a new pull request #6385: URL: https://github.com/apache/geode/pull/6385
Something to note when doing SSL testing: testcontainers does not let you set the container name (using `container_name` in your compose.yml). This ultimately means that reverse IP lookups produce hostnames that look something like `project_service_index`. The problem is that these names are not RFC compliant as they contain underscores. This can break some aspects of SSL validation. I've had to work around this by renaming containers in various test classes. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to [email protected]. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
