jdeppe-pivotal commented on a change in pull request #6385:
URL: https://github.com/apache/geode/pull/6385#discussion_r623380569
##########
File path:
geode-assembly/src/acceptanceTest/resources/org/apache/geode/cache/wan/docker-compose.yml
##########
@@ -17,12 +17,8 @@
version: '3'
services:
locator:
- container_name: 'locator'
image: 'geode:develop'
hostname: locator
- expose:
Review comment:
Totally agree, but I couldn't get _testcontainers_ to work properly with
the `expose` directives left in place. Possibly I'm doing something wrong. It
does do something a bit weird in that it spins up an _ambassador_ container
which proxies the connections to the actual containers. I think that may be
part of the need to not expose the ports, but I'm not sure. More details here:
https://www.testcontainers.org/modules/docker_compose/#example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
