nonbinaryprogrammer commented on a change in pull request #6296:
URL: https://github.com/apache/geode/pull/6296#discussion_r627584482
##########
File path:
geode-apis-compatible-with-redis/src/test/java/org/apache/geode/redis/internal/data/RedisHashTest.java
##########
@@ -258,11 +261,380 @@ public void
hscanSnaphots_shouldExpireAfterExpiryPeriod() {
});
}
+ /************* Hash Size *************/
+ /******* constants *******/
+ @Test
+ public void constantBaseRedisHashOverhead_shouldEqualCalculatedOverhead() {
+ ReflectionObjectSizer reflectionObjectSizer =
ReflectionObjectSizer.getInstance();
+ int baseRedisHashOverhead = reflectionObjectSizer.sizeof(new RedisHash());
+
+ assertThat(baseRedisHashOverhead).isEqualTo(BASE_REDIS_HASH_OVERHEAD);
+ }
Review comment:
they test slightly different things but since they have a lot of
overlapping code, I put both assertions in this test and deleted the other one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
