mreddington commented on a change in pull request #761:
URL: https://github.com/apache/geode-native/pull/761#discussion_r631129082
##########
File path: cppcache/integration-test/LibraryCallbacks.cpp
##########
@@ -29,7 +29,7 @@ void dummyFunc() {}
} // namespace test
#define SLEEP(x) std::this_thread::sleep_for(std::chrono::milliseconds(x))
-#define LOG LOGDEBUG
+#define LOG LOG_DEBUG
Review comment:
Our tests shouldn't be using the NC library logger, there's just no need
or justification for it. The test harness should be responsible for all
reporting. If the mocks and stated expectations and assertions are inadequate
to correctly deduce the nature of a failed test, that indicates the test is
inadequate. The test harness provides all the facilities necessary to express
expected sequences of operations and additional information. Each expectation
and and assertion returns a stream object for logging additional information.
For example:
`EXPECT_EQ(foo, bar) << "I BLAME ZOIDBERG!";`
There are other facilities for logging additional information, like the
`Gfsh` command output, that will only appear in the case of a failure. The test
harness should be quiet, with a clean indication of success, and fail with a
complete report. The harness knows how to do it. I recommend you map `LOG` to a
no-op, and we begin removing all logging from tests.
##########
File path: dependencies/spdlog/CMakeLists.txt
##########
@@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+project( spdlog VERSION 1.3.1 LANGUAGES NONE )
+
+set( SHA256 db6986d0141546d4fba5220944cc1f251bd8afdfc434bda173b4b0b6406e3cd0 )
+
+include(GNUInstallDirs)
+include(ExternalProject)
+
+ExternalProject_Add( ${PROJECT_NAME}-extern
+ URL "https://github.com/gabime/spdlog/archive/v${PROJECT_VERSION}.zip";
Review comment:
Is there a way we can track the tip of spdlog? Is that desirable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
