pdxcodemonkey commented on a change in pull request #761:
URL: https://github.com/apache/geode-native/pull/761#discussion_r631151376
##########
File path: cppcache/integration-test/LibraryCallbacks.cpp
##########
@@ -29,7 +29,7 @@ void dummyFunc() {}
} // namespace test
#define SLEEP(x) std::this_thread::sleep_for(std::chrono::milliseconds(x))
-#define LOG LOGDEBUG
+#define LOG LOG_DEBUG
Review comment:
Agree 100% in principle, but I think this is beyond the scope of the
current PR. To give you an idea of the size of this task, here is the result
of "find in files" for `LOG`, whole-word only, so I'd only catch test code that
was using some variation of this hokey define:
`Matching lines: 2609 Matching files: 112 Total files searched: 1167`
That's a whooooole lot of logging to go remove from code that is targeted
for deprecation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
