mmartell commented on a change in pull request #804:
URL: https://github.com/apache/geode-native/pull/804#discussion_r631366781
##########
File path: cppcache/src/ThinClientRegion.cpp
##########
@@ -1066,8 +1066,8 @@ GfErrType ThinClientRegion::removeNoThrow_remote(
// do TCR remove
TcrMessageDestroy request(new DataOutput(m_cacheImpl->createDataOutput()),
- this, keyPtr, cvalue, aCallbackArgument,
- m_tcrdm.get());
+ this, keyPtr, cvalue, cvalue == nullptr,
Review comment:
Since the region->remove() and region->destroy() APIs all use
TcrMessageDestroy, there's actually two types of Destroy messages that can be
sent to the server. This parameter is needed to send the proper one based on
whether the user is removing a key or a key and a value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
