mmartell commented on a change in pull request #804:
URL: https://github.com/apache/geode-native/pull/804#discussion_r631416519
##########
File path: cppcache/integration/test/CachingProxyTest.cpp
##########
@@ -51,86 +53,67 @@ class CachingProxyTest : public ::testing::Test {
~CachingProxyTest() override = default;
- void SetUp() override {}
+ void SetUp() override {
+ cache.getPoolManager()
+ .createFactory()
+ .addLocator("localhost", cluster.getLocatorPort())
+ .create("pool");
+
+ region = cache.createRegionFactory(RegionShortcut::CACHING_PROXY)
+ .setPoolName("pool")
+ .create("region");
+ }
void TearDown() override {}
Cluster cluster = Cluster{LocatorCount{1}, ServerCount{1}};
+ Cache cache = CacheFactory().create();
std::string key = std::string("scharles");
std::string value = std::string("Sylvia Charles");
+ std::shared_ptr<Region> region;
};
TEST_F(CachingProxyTest, LocalRemoveAfterLocalInvalidate) {
- auto cache = CacheFactory().create();
-
- cache.getPoolManager()
- .createFactory()
- .addLocator("localhost", cluster.getLocatorPort())
- .create("pool");
-
- auto region = cache.createRegionFactory(RegionShortcut::CACHING_PROXY)
- .setPoolName("pool")
- .create("region");
-
region->put(key, value);
auto user = region->get(key);
region->localInvalidate(key);
- bool resultLocalRemove = region->localRemove(key, value);
+ auto resultLocalRemove = region->localRemove(key, value);
ASSERT_FALSE(resultLocalRemove);
resultLocalRemove = region->localRemove(
- key, static_cast<std::shared_ptr<Cacheable>>(nullptr));
+ // key, static_cast<std::shared_ptr<Cacheable>>(nullptr));
Review comment:
Good catch. Thorough, that jbarrett is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
