mmartell commented on a change in pull request #804:
URL: https://github.com/apache/geode-native/pull/804#discussion_r631560421
##########
File path: cppcache/integration/test/CachingProxyTest.cpp
##########
@@ -51,86 +53,67 @@ class CachingProxyTest : public ::testing::Test {
~CachingProxyTest() override = default;
- void SetUp() override {}
+ void SetUp() override {
+ cache.getPoolManager()
+ .createFactory()
+ .addLocator("localhost", cluster.getLocatorPort())
+ .create("pool");
+
+ region = cache.createRegionFactory(RegionShortcut::CACHING_PROXY)
+ .setPoolName("pool")
+ .create("region");
+ }
void TearDown() override {}
Cluster cluster = Cluster{LocatorCount{1}, ServerCount{1}};
+ Cache cache = CacheFactory().create();
Review comment:
That feels a bit contrived. Maybe we should just follow the pattern in
the other new framework tests, which setup server and cache in each test.
Also, could you explain the danger with using the builder pattern to init a
member variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
