upthewaterspout commented on a change in pull request #6467:
URL: https://github.com/apache/geode/pull/6467#discussion_r632097467
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java
##########
@@ -94,9 +97,9 @@ public GeodeRedisServer(String bindAddress, int port,
InternalCache cache) {
nettyRedisServer = new NettyRedisServer(() ->
cache.getInternalDistributedSystem().getConfig(),
regionProvider, pubSub,
this::allowUnsupportedCommands, this::shutdown, port, bindAddress,
redisStats,
- redisCommandExecutor, member);
+ redisCommandExecutor, member, commandHelper);
- BucketInfoRetrievalFunction.register(bindAddress,
nettyRedisServer.getPort());
+ RedisMemberInfoRetrievalFunction.register(bindAddress,
nettyRedisServer.getPort());
Review comment:
I think there is a race condition where the region might be created but
the function is not registered yet ... that might lead to an error executing
the function. Maybe we need register the function earlier and set the bind
address & port later, or maybe handle that sort of error when we execute the
function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
