DonalEvans opened a new pull request #6487:
URL: https://github.com/apache/geode/pull/6487
- Replace uses of ByteArrayWrapper with byte[] in RedisSet,
NullRedisSet and other Set-related classes
- Replace internal Set in RedisSet with fastutil
ObjectOpenCustomHashSet
- Replace the membersAddAll and membersRemoveAll methods with looped
calls to membersAdd and membersRemove, as ObjectOpenCustomHashSet does
not implement addAll and removeAll, which causes errors when comparing
the contents of Sets
- Replace uses of implementations with interfaces where possible
- These changes break the sizing tests, but these tests have been
determined to be inconsistent due to the current implementation of
sizeable in RedisSet. GEODE-9279 will address the issues with sizeable
in a future commit
Authored-by: Donal Evans <doev...@vmware.com>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [N/A] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
