sabbey37 edited a comment on pull request #6487: URL: https://github.com/apache/geode/pull/6487#issuecomment-843372066
> I don't know too much about the TCL test, but I thought this was a refactoring that shouldn't have affected them. What are the changes to the TCL tests about? The Native Redis test for `EXPIRE - write on expire should work` were utilizing `lpush`. We did not have that command/the list data structure implemented, so at some point they were changed to do a `sadd`. The tests also checks the result of `smembers`. Since sets don't have a fixed order, it failed (but seems like this happened very infrequently since it was only just caught). The test was changed to use a `set` on a string (it didn't seem to matter which data set was used, since the test just verified that we could continue to edit the value after an expiration was set). That was all that was changed in the tcl tests, but the whole patch file was replaced (including all the same changes as before) vs. trying to edit it directly. Looks like some set Native Redis tests are failing with the new changes though. I'm not sure what that's about (haven't looked at the full PR yet), but shouldn't have anything to do with the patch file change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
