DonalEvans commented on pull request #6487: URL: https://github.com/apache/geode/pull/6487#issuecomment-847262731
Regarding the set copying that Dan mentioned, I agree that it's something we want to avoid and get rid of, but the sets used in the diff and intersection operations need to be a class that can handle comparisons between byte arrays in the way we want. However, returning a `ObjectOpenCustomHashSet` from the lambdas in `RedisSetCommandsFunctionExecutor.internalsmembers()` or `RedisSetCommandsFunctionExecutor.smembers()` results in serialization filter errors, so as a compromise, this set copying behaviour is used to allow a `HashSet` to be returned from the lambda and then turned back into a `ObjectOpenCustomHashSet` when needed for diff and intersection. Since these commands aren't currently supported, this bevaiour should be revisited when they're fully implemented and supported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
