albertogpz commented on a change in pull request #6036:
URL: https://github.com/apache/geode/pull/6036#discussion_r642939650
##########
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationLoopBackDUnitTest.java
##########
@@ -410,9 +410,9 @@ public void
unstartedSenderShouldNotAddReceivedEventsIntoTmpDropped() {
vm3.invoke(() -> WANTestBase.validateRegionSize(getTestMethodName() +
"_PR", 100));
vm5.invoke(() -> WANTestBase.validateRegionSize(getTestMethodName() +
"_PR", 100));
- // verify tmpDroppedEvents should be 100 at site-ln, because the sender is
not started yet
- vm3.invoke(() -> WANTestBase.verifyTmpDroppedEventSize("ln", 100));
- vm5.invoke(() -> WANTestBase.verifyTmpDroppedEventSize("ln", 100));
+ // verify tmpDroppedEvents should be 0 at site-ln, because the sender is
not started yet
+ vm3.invoke(() -> WANTestBase.verifyTmpDroppedEventSize("ln", 0));
+ vm5.invoke(() -> WANTestBase.verifyTmpDroppedEventSize("ln", 0));
Review comment:
I understand. Given that tmpDroppedEvents does not seem to be used in
this case, maybe the comments in the test case should be updated and it would
be great to have another test case in which tmpDroppedEvents is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
