albertogpz commented on a change in pull request #6036:
URL: https://github.com/apache/geode/pull/6036#discussion_r682651995
##########
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationLoopBackDUnitTest.java
##########
@@ -365,9 +365,9 @@ public void
testParallelPropagationLoopBack3SitesNtoNTopologyPutFromOneDS() {
* Site-NY: dsid=1: senderId="ln": vm3, vm6
* NY site's sender's manual-start=true
*
- * Make sure the events are sent from LN to NY and will not be added into
tmpDroppedEvents
- * while normal events put from NY site can still be added to
tmpDroppedEvents
- * Start the sender, make sure the events in tmpDroppedEvents are sent to LN
finally
+ * Verify that events aren't added to tmpDroppedEvents after gateway-sender
is recovered in
+ * stopped state with manual-start=true, and that none of the events are
sent to remote site
+ * after sender is started.
Review comment:
I do not see in this case that the sender is recovered in stopped state.
The only thing I see is that it is started.
This test case might need some rethinking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]