albertogpz commented on a change in pull request #6659:
URL: https://github.com/apache/geode/pull/6659#discussion_r660340441
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java
##########
@@ -248,7 +248,9 @@ public void firePendingCallbacks() {
lastTransactionEvent =
TXLastEventInTransactionUtils.getLastTransactionEvent(getPendingCallbacks(),
getCache());
} catch (ServiceConfigurationError ex) {
- logger.error(ex.getMessage());
+ if
(!ex.getMessage().startsWith(TXLastEventInTransactionUtils.NO_INFORMATION_FOR_SENDER_ID))
{
+ logger.error(ex.getMessage());
+ }
Review comment:
The same comment as in TXCommitMessage would apply here.
##########
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagation_PartitionedRegionDUnitTest.java
##########
@@ -78,6 +78,41 @@ public void testPartitionedSerialPropagation() {
vm2.invoke(() -> WANTestBase.validateRegionSize(getTestMethodName() +
"_PR", 1000));
}
+ @Test
+ public void testPartitionedSerialPropagationWithTransaction() {
Review comment:
I would add in the test case name that the senders are not configured in
all servers.
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/TXCommitMessage.java
##########
@@ -733,7 +733,9 @@ void firePendingCallbacks(List<EntryEventImpl> callbacks) {
try {
lastTransactionEvent = getLastTransactionEvent(callbacks);
} catch (ServiceConfigurationError ex) {
- logger.error(ex.getMessage());
+ if
(!ex.getMessage().startsWith(TXLastEventInTransactionUtils.NO_INFORMATION_FOR_SENDER_ID))
{
+ logger.error(ex.getMessage());
+ }
Review comment:
If this is not necessarily a configuration error, instead of removing
the error log, I would update
`TXLastEventInTransactionUtils.checkNoSendersGroupTransactionEvents()` to
return `false` in case a sender is null as follows:
```
if (sender == null || sender.mustGroupTransactionEvents()) {
return false;
}
```
A similar change would have to be done in
`TXLastEventInTransactionUtils.doesSenderGroupTransactionEvents`:
`return sender == null || sender.mustGroupTransactionEvents();`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
