agingade edited a comment on pull request #6659:
URL: https://github.com/apache/geode/pull/6659#issuecomment-871789431
@pivotal-eshu
It looks like the Tx code is trying to assess Gateway sender requirement to
support GEODE-7971 in TX code. Which doesn't seems right.
The "getLastTransactionEvent" should just return the last event in the
transaction; currently it is doing it by "callbacks.get(callbacks.size() - 1);"
which also seems to be error prone or inefficient.
In "firePendingCallbacks" it could have iterated over the list using size
index:
for (int i=0; i<callbaack.size(); i++){
ee.getRegion().invokeTXCallbacks(EnumListenerEvent.AFTER_DESTROY, ee, true,
(i+1) == size() /*isLastTrasaction*/);
}
Please correct me if i am missing anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
