pivotal-jbarrett commented on a change in pull request #6697:
URL: https://github.com/apache/geode/pull/6697#discussion_r670679545



##########
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/FilterRoutingInfo.java
##########
@@ -386,121 +330,121 @@ public void toData(DataOutput out) throws IOException {
       byte[] myData = StaticSerialization.getThreadLocalByteArray(size);
       hdos = new HeapDataOutputStream(myData);
       hdos.disallowExpansion();
-      if (this.cqs == null) {
+      if (cqs == null) {
         hdos.writeBoolean(false);
       } else {
         hdos.writeBoolean(true);
         InternalDataSerializer.writeArrayLength(cqs.size(), hdos);
-        for (Iterator it = this.cqs.entrySet().iterator(); it.hasNext();) {
-          Map.Entry e = (Map.Entry) it.next();
+        for (final Map.Entry<Long, Integer> longIntegerEntry : cqs.entrySet()) 
{
           // most cq IDs and all event types are small ints, so we use an 
optimized
           // write that serializes 7 bits at a time in a compact form
-          InternalDataSerializer.writeUnsignedVL((Long) e.getKey(), hdos);
-          InternalDataSerializer.writeUnsignedVL((Integer) e.getValue(), hdos);
+          InternalDataSerializer.writeUnsignedVL(longIntegerEntry.getKey(), 
hdos);
+          InternalDataSerializer.writeUnsignedVL(longIntegerEntry.getValue(), 
hdos);
         }
       }
-      InternalDataSerializer.writeSetOfLongs(this.interestedClients, 
this.longIDs, hdos);
-      InternalDataSerializer.writeSetOfLongs(this.interestedClientsInv, 
this.longIDs, hdos);
+      InternalDataSerializer.writeSetOfLongs(interestedClients, longIDs, hdos);
+      InternalDataSerializer.writeSetOfLongs(interestedClientsInv, longIDs, 
hdos);

Review comment:
       There is a PR pending that removes 8.0.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to