pivotal-jbarrett commented on a change in pull request #6697:
URL: https://github.com/apache/geode/pull/6697#discussion_r670872385
##########
File path:
geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/MemberIdentifierImpl.java
##########
@@ -284,7 +279,7 @@ public int compareTo(MemberIdentifier other, boolean
compareMemberData,
String myName = getName();
String otherName = other.getName();
- if (!(other.isPartial() || this.isPartial())) {
+ if (!(other.isPartial() || isPartial())) {
if (myName == null && otherName == null) {
Review comment:
I want to. I really do. I was worried about the readability change in
similar empty blocks like this. Let me noodle it and see if refactoring it
changes the readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
