pivotal-jbarrett commented on a change in pull request #831:
URL: https://github.com/apache/geode-native/pull/831#discussion_r672432754
##########
File path: cppcache/test/ByteArrayFixture.cpp
##########
@@ -20,7 +20,7 @@
::testing::AssertionResult ByteArrayFixture::assertByteArrayEqual(
const char* /*expectedStr*/, const char* /*bytesStr*/, const char*
expected,
const apache::geode::client::ByteArray& bytes) {
- // One would normally just use std::regex but gcc 4.4.7 is lacking.
+ // One would normally just use boost::regex but gcc 4.4.7 is lacking.
Review comment:
How about just resolving the issue in the comment. We don't support GCC
4.4.7 anymore.
##########
File path: cppcache/include/geode/CacheableString.hpp
##########
@@ -54,11 +54,11 @@ class APACHE_GEODE_EXPORT CacheableString
: m_str(std::move(value)), m_hashcode(0) {
bool ascii = isAscii(m_str);
- m_type = m_str.length() > (std::numeric_limits<uint16_t>::max)()
- ? ascii ? DSCode::CacheableASCIIStringHuge
- : DSCode::CacheableStringHuge
- : ascii ? DSCode::CacheableASCIIString
- : DSCode::CacheableString;
+ m_type =
+ m_str.length() > (std::numeric_limits<uint16_t>::max)()
+ ? ascii ? DSCode::CacheableASCIIStringHuge
+ : DSCode::CacheableStringHuge
+ : ascii ? DSCode::CacheableASCIIString : DSCode::CacheableString;
Review comment:
Did you make these changes on Windows? The CI version and macOS version
seem to be in agreement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
