pdxcodemonkey commented on a change in pull request #831:
URL: https://github.com/apache/geode-native/pull/831#discussion_r673218319
##########
File path: cppcache/test/ByteArrayFixture.cpp
##########
@@ -20,7 +20,7 @@
::testing::AssertionResult ByteArrayFixture::assertByteArrayEqual(
const char* /*expectedStr*/, const char* /*bytesStr*/, const char*
expected,
const apache::geode::client::ByteArray& bytes) {
- // One would normally just use std::regex but gcc 4.4.7 is lacking.
+ // One would normally just use boost::regex but gcc 4.4.7 is lacking.
Review comment:
Hmmm, impenetrable test code with a somewhat cryptic comment about a
compiler we no longer use. How about we just delete the comment and move on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
