jdeppe-pivotal commented on a change in pull request #6704:
URL: https://github.com/apache/geode/pull/6704#discussion_r676960935
##########
File path:
geode-apis-compatible-with-redis/src/distributedTest/java/org/apache/geode/redis/internal/executor/pubsub/PubSubDUnitTest.java
##########
@@ -209,20 +210,18 @@ public void
shouldContinueToFunction_whenOneServerShutsDownGracefully_givenTwoSu
MockSubscriber mockSubscriber1 = new MockSubscriber(latch);
MockSubscriber mockSubscriber2 = new MockSubscriber(latch);
- Future<Void> subscriber1Future =
- executor.submit(() -> subscriber1.subscribe(mockSubscriber1,
CHANNEL_NAME));
+ executor.submit(() -> subscriber1.subscribe(mockSubscriber1,
CHANNEL_NAME));
Future<Void> subscriber2Future =
executor.submit(() -> subscriber2.subscribe(mockSubscriber2,
CHANNEL_NAME));
assertThat(latch.await(30, TimeUnit.SECONDS)).as("channel subscription was
not received")
.isTrue();
- Long result = publisher1.publish(CHANNEL_NAME, "hello");
- assertThat(result).isEqualTo(2);
+ publisher1.publish(CHANNEL_NAME, "hello");
Review comment:
We do have tests that cover that - see for example
`AbstractPubSubIntegrationTest.testOneSubscriberOneChannel`. Although, I don't
see how the response can be meaningful to a client anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
