jdeppe-pivotal commented on a change in pull request #6704:
URL: https://github.com/apache/geode/pull/6704#discussion_r678394175



##########
File path: 
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/pubsub/PubSubImpl.java
##########
@@ -42,13 +47,45 @@
 public class PubSubImpl implements PubSub {
   public static final String REDIS_PUB_SUB_FUNCTION_ID = 
"redisPubSubFunctionID";
 
+  private static final int DEFAULT_PUBLISH_THREAD_COUNT =
+      Integer.getInteger("redis.publish-thread-count", 100);
+
   private static final Logger logger = LogService.getLogger();
 
   private final Subscriptions subscriptions;
+  private final ExecutorService executor;
+
+  /**
+   * Inner class to wrap the publish action and pass it to the {@link 
StripedExecutorService}.
+   */
+  private static class PublishingRunnable implements StripedRunnable {
+
+    private final Runnable runnable;
+    private final Object stripeIdentity;

Review comment:
       I don't want to obscure the fact that the API only cares about the 
stripe object reference, but since it's a very specific use I can see your 
point.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to